Author: petdance Date: Mon Jan 5 00:02:34 2009 New Revision: 34967 Added: trunk/tools/util/perlcritic-cage.conf (contents, props changed) Modified: trunk/config/gen/makefiles/root.in Log: working on the more stringent perlcritic-cage target Modified: trunk/config/gen/makefiles/root.in ============================================================================== --- trunk/config/gen/makefiles/root.in (original) +++ trunk/config/gen/makefiles/root.in Mon Jan 5 00:02:34 2009 @@ -738,6 +738,7 @@ @echo " cover: Run test suite coverage analysis." @echo " tags-vi: Create tags for the vi editor." @echo " tags-emacs: Create tags for the EMACS editor." + @echo " perlcritic: Check Perl code with Perl::Critic." @echo "" @echo "Release:" @echo " release: Create a tarball." @@ -2236,6 +2237,13 @@ tags.vi.dummy: +perlcritic: + perlcritic --profile tools/util/perlcritic.conf + +# Andy's extra-cranky Perl::Critic checking for cage cleaners +cagecritic: + perlcritic -1 --profile tools/util/perlcritic-cage.conf lib/Parrot + # This target will eventually create all the headers automatically. If you are # having problems with linkage in Win32 (or elsewhere), because something is # not PARROT_EXPORT but should be, then put PARROT_EXPORT in the C file and run "make Added: trunk/tools/util/perlcritic-cage.conf ============================================================================== --- (empty file) +++ trunk/tools/util/perlcritic-cage.conf Mon Jan 5 00:02:34 2009 @@ -0,0 +1,30 @@ +# A more stringent set of rules for cage cleaners + +[-CodeLayout::ProhibitParensWithBuiltins] +[CodeLayout::ProhibitHardTabs] +allow_leading_tabs = 0 + +[-CodeLayout::RequireTidyCode] + +[-ControlStructures::ProhibitPostfixControls] + +[-Documentation::RequirePodAtEnd] +[-Documentation::RequirePodSections] + +[-Editor::RequireEmacsFileVariables] +[-ErrorHandling::RequireCarping] + +[-InputOutput::ProhibitInteractiveTest] +[-InputOutput::ProhibitBacktickOperators] + +[-Miscellanea::RequireRcsKeywords] + +[-Modules::RequireVersionVar] + +[-RegularExpressions::RequireExtendedFormatting] +[-RegularExpressions::RequireLineBoundaryMatching] + +[-ValuesAndExpressions::ProhibitConstantPragma] +[-ValuesAndExpressions::ProhibitEmptyQuotes] + +[-Variables::ProhibitPunctuationVars]