develooper Front page | perl.cvs.parrot | Postings from January 2009

[svn:parrot] r35127 - in trunk: docs include/parrot src

From:
coke
Date:
January 7, 2009 07:54
Subject:
[svn:parrot] r35127 - in trunk: docs include/parrot src
Message ID:
20090107155425.52122CB9F9@x12.develooper.com
Author: coke
Date: Wed Jan  7 07:54:24 2009
New Revision: 35127

Modified:
   trunk/docs/embed.pod
   trunk/include/parrot/global.h
   trunk/src/global.c

Log:
remove Parrot_store_global_k, only used by a long-[DEPRECATED] and now removed opcode

Modified: trunk/docs/embed.pod
==============================================================================
--- trunk/docs/embed.pod	(original)
+++ trunk/docs/embed.pod	Wed Jan  7 07:54:24 2009
@@ -357,11 +357,6 @@
 Find and return a global called C<name> in the keyed namespace C<namespace>.
 Returns C<PMCNULL> if not found.
 
-=item C<void Parrot_store_global_k(PARROT_INTERP, Parrot_PMC namespace_key, Parrot_String name, Parrot_PMC val)>
-
-Sets the value of a global called C<name> in the keyed namespace C<namespace>.
-Does nothing if the global is not found.
-
 =back
 
 =head3 Lexicals

Modified: trunk/include/parrot/global.h
==============================================================================
--- trunk/include/parrot/global.h	(original)
+++ trunk/include/parrot/global.h	Wed Jan  7 07:54:24 2009
@@ -138,14 +138,6 @@
         __attribute__nonnull__(1);
 
 PARROT_EXPORT
-void Parrot_store_global_k(PARROT_INTERP,
-    ARGIN(PMC *pmc_key),
-    ARGIN_NULLOK(STRING *globalname),
-    ARGIN_NULLOK(PMC *val))
-        __attribute__nonnull__(1)
-        __attribute__nonnull__(2);
-
-PARROT_EXPORT
 void Parrot_store_global_n(PARROT_INTERP,
     ARGIN_NULLOK(PMC *ns),
     ARGIN_NULLOK(STRING *globalname),
@@ -205,9 +197,6 @@
     || PARROT_ASSERT_ARG(_namespace)
 #define ASSERT_ARGS_Parrot_set_global __attribute__unused__ int _ASSERT_ARGS_CHECK = \
        PARROT_ASSERT_ARG(interp)
-#define ASSERT_ARGS_Parrot_store_global_k __attribute__unused__ int _ASSERT_ARGS_CHECK = \
-       PARROT_ASSERT_ARG(interp) \
-    || PARROT_ASSERT_ARG(pmc_key)
 #define ASSERT_ARGS_Parrot_store_global_n __attribute__unused__ int _ASSERT_ARGS_CHECK = \
        PARROT_ASSERT_ARG(interp)
 #define ASSERT_ARGS_Parrot_store_global_s __attribute__unused__ int _ASSERT_ARGS_CHECK = \

Modified: trunk/src/global.c
==============================================================================
--- trunk/src/global.c	(original)
+++ trunk/src/global.c	Wed Jan  7 07:54:24 2009
@@ -652,47 +652,6 @@
 
 /*
 
-=item C<void Parrot_store_global_k>
-
-Store the PMC C<val> into the namespace designated by C<pmc_key>,
-which may be a key PMC, an array of namespace name strings, or a
-string PMC, with name C<globalname>.
-
-RT #46161 - For now this function prefers non-namespaces, it will eventually
-entirely use the untyped interface.
-
-=cut
-
-*/
-
-PARROT_EXPORT
-void
-Parrot_store_global_k(PARROT_INTERP, ARGIN(PMC *pmc_key),
-        ARGIN_NULLOK(STRING *globalname), ARGIN_NULLOK(PMC *val))
-{
-    ASSERT_ARGS(Parrot_store_global_k)
-    PMC *ns;
-
-    /*
-     * RT #46167 - temporary hack to notice when key is actually a string, so that
-     * the legacy logic for invalidating method cache will be called; this is
-     * not good enough but it avoids regressesions for now
-     */
-    if (pmc_key->vtable->base_type == enum_class_String) {
-        Parrot_store_global_s(interp, PMC_str_val(pmc_key),
-                              globalname, val);
-        return;
-    }
-
-    ns = Parrot_make_namespace_keyed(interp,
-                                     Parrot_get_ctx_HLL_namespace(interp),
-                                     pmc_key);
-
-    Parrot_store_global_n(interp, ns, globalname, val);
-}
-
-/*
-
 =item C<void Parrot_store_global_s>
 
 Store the PMC C<val> into the namespace designated by C<str_key>, or



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About