develooper Front page | perl.perl5.changes | Postings from February 2023

[Perl/perl5] 3cc265: Replace "define\t" with "define " inConfigure/met...

From:
Yves Orton via perl5-changes
Date:
February 21, 2023 14:59
Subject:
[Perl/perl5] 3cc265: Replace "define\t" with "define " inConfigure/met...
Message ID:
Perl/perl5/push/refs/heads/yves/fix_define_tab/e7e2be-3407fd@github.com
  Branch: refs/heads/yves/fix_define_tab
  Home:   https://github.com/Perl/perl5
  Commit: 3cc2653e10203bf2999bc7dbe5b0f870ea6aa9e0
      https://github.com/Perl/perl5/commit/3cc2653e10203bf2999bc7dbe5b0f870ea6aa9e0
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M Configure
    M Porting/config_H
    M Porting/config_h.pl
    M config_h.SH

  Log Message:
  -----------
  Replace "define\t" with "define " in Configure/metaconfig related files

This is broken out so it is easier for Tux to find and merge with
metaconfig.

View this patch with -w and you will see "no changes" except for
config_h.SH and Porting/config_h.pl both which needed to be changed to
ensure that they produce output that doesn't replicate the problem.


  Commit: 5d8135618090dce6c2a22034edd78fb929c58f33
      https://github.com/Perl/perl5/commit/5d8135618090dce6c2a22034edd78fb929c58f33
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M dist/IO/ChangeLog
    M dist/IO/IO.pm
    M dist/IO/lib/IO/Dir.pm
    M dist/IO/lib/IO/File.pm
    M dist/IO/lib/IO/Handle.pm
    M dist/IO/lib/IO/Pipe.pm
    M dist/IO/lib/IO/Poll.pm
    M dist/IO/lib/IO/Seekable.pm
    M dist/IO/lib/IO/Select.pm
    M dist/IO/lib/IO/Socket.pm
    M dist/IO/lib/IO/Socket/INET.pm
    M dist/IO/lib/IO/Socket/UNIX.pm
    M dist/IO/poll.h

  Log Message:
  -----------
  dist/IO: replace "define\t" with "define "

This cleans up the defines in dist/IO/poll.h.

"#define\t" is annoying as it is it 8 spaces wide, so it looks like
"#define ", yet will not be found in a grep for "define foo" as the
space is actually a tab.


  Commit: 194bf7e4036aadf1bf76919296fce38dc81f1444
      https://github.com/Perl/perl5/commit/194bf7e4036aadf1bf76919296fce38dc81f1444
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M ext/File-Glob/Glob.pm
    M ext/File-Glob/bsd_glob.c
    M ext/File-Glob/bsd_glob.h

  Log Message:
  -----------
  ext/File-Glob/ - replace "define\t" with "define "

"#define\t" is annoying as it is it 8 spaces wide, so it looks like
"#define ", yet will not be found in a grep for "define foo" as the
space is actually a tab.


  Commit: 3dcc27bd69fd354fc28931617a47298daf815a51
      https://github.com/Perl/perl5/commit/3dcc27bd69fd354fc28931617a47298daf815a51
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M ext/SDBM_File/SDBM_File.pm
    M ext/SDBM_File/dbu.c

  Log Message:
  -----------
  ext/SDBM_File/ - replace "define\t" with "define "

"#define\t" is annoying as it is it 8 spaces wide, so it looks like
"#define ", yet will not be found in a grep for "define foo" as the
space is actually a tab.


  Commit: 3407fdfd2a3aa56a621c19c6b6b2e10aa8b64d74
      https://github.com/Perl/perl5/commit/3407fdfd2a3aa56a621c19c6b6b2e10aa8b64d74
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
    M cop.h
    M malloc.c
    M op.h
    M os2/os2ish.h
    M patchlevel.h
    M plan9/config.plan9
    M plan9/config_h.sample
    M plan9/plan9ish.h
    M regcomp.h
    M regexec.c
    M t/uni/stash.t
    M uconfig.h
    M unixish.h
    M util.c
    M vms/vmsish.h
    M win32/config_H.gc
    M win32/config_H.vc
    M win32/include/sys/socket.h
    M win32/win32.h
    M win32/win32iop.h

  Log Message:
  -----------
  replace "define\t" with "define " in most "normal" core files.

The main exceptions being dist/, ext/, and Configure related
files, which will be updated in a subsequent commit. Files in the cpan/
directory are also omitted as they are not owned by the core.

'#define' has seven characters, so following it with a \t makes it look
like '#define ' when it is not, which then frustrates attempts to find
where a given define is. If you *know* then you do a

    git grep -P 'define\s+WHATEVER'

but if don't or you forget, you can get very confused trying to find
where a given define is located. This fixes all such cases so they
actually are 'define WHATEVER' instead.

If this patch is getting in your way with blame analysis then view it
with the -w option to blame.


Compare: https://github.com/Perl/perl5/compare/e7e2bec62815...3407fdfd2a3a



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About