Front page | perl.perl5.porters |
Postings from March 2023
On Fri, 3 Mar 2023 at 21:30, Zefram via perl5-porters <perl5-porters@perl.org> wrote: > > demerphq wrote: > >Very annoyingly I misused git in such a way that when i thought i was > >pushing my branch with your patch to github as a branch which would > >become a PR I actually pushed it directly to blead as a commit. > > Lucky it was such an uncontroversial change. Indeed. :-) > > You note in the commit message a need to update the customisation list. > Turns out that, per Porting/Maintainers.pl, that file actually belongs to > the Filter(-Util-Call) distro, upstream CPAN. Maybe i misread, but i couldn't find a document in File-Util-Call that matched pod/perlfilter.pod. If I had i wouldnt have pushed it and requested you patch the right file. But the the pod in Call.pm doesnt use the word perlfilter even once, nor the word piracy. In fact I couldnt find the word "piracy" in cpan/Filter-Util-Call at all. Which is why i was a bit perplexed that i needed the customization entry. > So in principle I should > have first submitted the change there, to Reini. I'm afraid I completely > missed that aspect of the file. If one doesn't know a priori then it > only becomes apparent from the customisation test. I didn't apply the > patch and run tests; Yves did. I'll report the patch upstream. > > The reason why there's already a customisation entry for that file is > that it's already customised by removing the L<> markup on its reference > to Filter::Util::Call, and by changing "use strict; use warnings;" to > "use v5.36;" in a code example. Am I going nuts? Which file do you mean? Call.pm? The content in Call.pm and perlfilter.pod don't look remotely like each other to my (rather tired) eyes just at the moment. I even tried diffing them, and there are relatively few lines shared between the two files. What am I missing?! > to perform even if it constitutes a core customisation, because of > the prominence that the core gives the document as a perlwhatever(1). > It needs to reflect our values, more so than if it's just documentation > of a bundled module. Totally agree there. cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next